emanifest backend logic separation and Floating Acion Buttons #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… used to encapsulate intereactions with e-Manifest (the RCRAInfo module) we're extracting the e-Manifest parts of the manifest service to help keep the separation of responsiblities clear
…ifest to RCRAInfo or just saving a manifest to haztrak
…hing async thunks or custom hook API calls. In effect, we are centralizing our API layer into the redux store
…RAInfo web services
…utput selectors that returned input values. The warning stated that likely would result in memoization errors. See the redux documentation https://redux.js.org/usage/deriving-data-selectors\#writing-memoized-selectors-with-reselect Add new selectHaztrakSiteEpaIds redux selector
…is using the RCRAInfo site search services, into separate component. The badge also shows a warning when a user's organization admin has not set up their RCRAInfo API ID and Keys in RCRAInfo.
…ry for dot ID number selection. Also, the component fetched and pre-populate DOT ID numbers with options upon mounting
…, aimed at implementing material design's FAB
… various actions depending on the manifest state
Adjust ManifestForm test suite to accommodate multiple save buttons (one floating action button, one regular) Minor changes to make HtSpinner for flexible and use correct profile selector in Profile Feature
github-actions
bot
added
client
dpgraham4401
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR separates our backend business logic that deals with interacting with e-Manifest from our back end business logic that deals with our manifest model.
I also went a little overboard and also added two new features to the UI.
Sign,Edit, orSavedepending on the user's permissions and the manifest status.In addition, the HandlerSearchForm now displays both RCRA sites that haztrak has stored in it's database (which are usually retrieved quickly and are, of course, only dependent on our service) and sites retrieved from RCRAInfo (often additional latency associated with the additional service call and may be unavailable).
Issue ticket number and link
Checklist